I replaced front pads - pretty routine. But now I have extremely noise calipers clattering when I hit bumps or pot holes on the road. I didn't know what it was at first but after I started looking I noticed they're not staying tight against the rotor. Is this a fault of the spring clip that goes on to hold them together?

 

Make sure that you did not bend the dust shield behind the rotor. If the dust shield was bent close to the rotor it could be hitting the rotor when you make turns or go over bumps. If it is too close, just bend it back.